Crash on changing repaire unit from wheels to half tracks

[wzdev-ci]

resolution_fixed type_bug | by anonymous

---

While changing all units from wheels to half tracks wz crashes without any error if half tracks are selected for repaire unit. I could reproduce behaviour but not in every attempt.

---

Issue migrated from trac:523 at 2022-04-15 18:19:30 -0700

[wzdev-ci]

anonymous uploaded file stderr.txt (1.2 KiB)

Error report

[wzdev-ci]

anonymous uploaded file warzone2100.RPT (3.0 KiB)

Call stack

[wzdev-ci]

anonymous uploaded file savegame.7z (116.3 KiB)

Savegame

[wzdev-ci]

Buginator commented

---

What language are you playing the game?

[wzdev-ci]

Buginator changed status from new to closed

[wzdev-ci]

Buginator set resolution to needinfo

[wzdev-ci]

Buginator changed milestone from 2.2 to 2.3

[wzdev-ci]

Buginator commented

---

Will reopen when I get the requested info.

[wzdev-ci]

Raffael Joliet <raffael.joliet@...> commented

---

Replying to Warzone2100/old-trac-import#523 (comment:1):

What language are you playing the game?

I installed it in german but changed to english (by menu) because i assumed some special characters to cause problems first. Problem is the same

[wzdev-ci]

Buginator changed resolution from needinfo to fixed

[wzdev-ci]

Buginator commented

---

(In [7486]) Check if the unit has weapons, before trying to see what weapons they have.

Fixes #523

[wzdev-ci]

Buginator commented

---

Thanks for the save game, I fixed the issue.

[wzdev-ci]

Buginator commented

---

(In [7487]) Check if the unit has weapons, before trying to see what weapons they have.

Fixes #523

[wzdev-ci]

Buginator commented

---

(In [7488]) backport [7481]-[7487]

On certain mission types (limbo & expand) we still have valid map data that is saved in-between the sub missions, and the radarblip drawing code didn't filter things that are outside the current scroll limits of the map.

Excise code of useless abort() & use ASSERT_OR_RETURN to prevent GIGO, and also fix miscellaneous issues of removing '\n', 'watermelon', and other things that made by eyes bug out.

NOTE, there should be no logic changes besides converting ASSERT() to ASSERT_OR_RETURN()!

--
Use ASSERT_OR_RETURN to prevent GIGO, and also fix miscellaneous issues of removing '\n', 'watermelon', and other things that made by eyes bug out.

NOTE, there should be no logic changes besides converting ASSERT() to ASSERT_OR_RETURN()!

--
Check if the unit has weapons, before trying to see what weapons they have.

Fixes #523

fixes #499

[wzdev-ci]

cybersphinx changed milestone from 3.0 to unspecified

[wzdev-ci]

cybersphinx commented

---

Milestone 3.0 deleted