Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Never add completed researches to research menu.

Researches would fail to disappear from the research menu when the research was complete, if clicking on the
research facility just before the research was complete, since this resulted in setting the research to pending,
and the research would still be pending even after being complete (more likely with high latency, due to a larger
window to reproduce in).

Fixes ticket:3454.
  • Loading branch information...
commit d37f5276a17bbff963e5d59d1fcb2e744b494ac2 1 parent 594b8a6
Cyp authored September 15, 2012

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. 2  src/hci.cpp
2  src/hci.cpp
@@ -5436,7 +5436,7 @@ static BASE_STATS *getResearchStats(BASE_OBJECT *psObj)
5436 5436
 	psBuilding = (STRUCTURE *)psObj;
5437 5437
 	psResearchFacility = &psBuilding->pFunctionality->researchFacility;
5438 5438
 
5439  
-	if (psResearchFacility->psSubjectPending != NULL)
  5439
+	if (psResearchFacility->psSubjectPending != NULL && !IsResearchCompleted(&asPlayerResList[psObj->player][psResearchFacility->psSubjectPending->index]))
5440 5440
 	{
5441 5441
 		return psResearchFacility->psSubjectPending;
5442 5442
 	}

0 notes on commit d37f527

Please sign in to comment.
Something went wrong with that request. Please try again.