Commits on May 13, 2012

  1. Revert "Update version numbers for 3.1 beta10."

    This reverts commit 968172d.
    
    Revert "Update translations."
    
    This reverts commit 29a0bd7.
    cybersphinx committed May 13, 2012
    Configuration menu
    Copy the full SHA
    4a1e029 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2012

  1. Configuration menu
    Copy the full SHA
    6365f2d View commit details
    Browse the repository at this point in the history
  2. Polish translation update by Emdek.

    Closes #1347.
    cybersphinx committed May 19, 2012
    Configuration menu
    Copy the full SHA
    9fc92b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    badb8c0 View commit details
    Browse the repository at this point in the history
  4. Hungarian translation update by mtomi78.

    Closes #3485.
    cybersphinx committed May 19, 2012
    Configuration menu
    Copy the full SHA
    d74ebad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a400fe0 View commit details
    Browse the repository at this point in the history
  6. Dutch translation update by nino_romans.

    Closes #3484.
    cybersphinx committed May 19, 2012
    Configuration menu
    Copy the full SHA
    c46d2d5 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2012

  1. Fix some typos.

    Thanks to pabs for noticing one of them. Closes #3495.
    cybersphinx committed May 20, 2012
    Configuration menu
    Copy the full SHA
    52511ce View commit details
    Browse the repository at this point in the history
  2. fix an FTBFS with -Werror=format-security

    Fixes ticket:3493.
    pabs3 authored and Cyp committed May 20, 2012
    Configuration menu
    Copy the full SHA
    e5d2242 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2012

  1. Fix flag loading code to work for out of sequence factories.

    fixes ticket:3384
    vexed committed May 21, 2012
    Configuration menu
    Copy the full SHA
    737b3d9 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'bugfixes' into 3.1

    automerge authored and cybersphinx committed May 21, 2012
    Configuration menu
    Copy the full SHA
    f04b5dd View commit details
    Browse the repository at this point in the history
  3. Fix communication between remaining clients when one client freezes.

    Problem persisted until the frozen client drops completely, or unfreezes (net connection is restored).
    
    To reproduce, test with host and 2 other clients, and freeze one client with kill -STOP or by pausing the net
    connection somehow.
    
    Cause was lack of flushing, due to an inverted condition exposed in b9cc770 and
    introduced in c1ca4d2. Would probably trigger before
    b9cc770, for any remaining clients that freeze for any reason (for example, because
    of <2.5 FPS or momentary hard drive swapping) for more than 400ms.
    Cyp committed May 21, 2012
    Configuration menu
    Copy the full SHA
    e14c39f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bedd870 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a80f040 View commit details
    Browse the repository at this point in the history
  6. Fix Nexus AI unable to build units.

    Nexus was building units with an unresearched sensor (equivalent to the default sensor). Since
    6365f2d, Nexus can no longer build unresearched units.
    
    In the tutorial, the designed MG viper wheels would also use the same unresearched sensor.
    
    Replaced unresearched DefaultSensor1Mk1 with ZNULLSENSOR. Removed special case for tutorial in
    7079ad2, which is no longer required.
    Cyp committed May 21, 2012
    Configuration menu
    Copy the full SHA
    f0eea79 View commit details
    Browse the repository at this point in the history
  7. Fix unconventional reported unit count on selecting all units of same…

    … type.
    
    Previous unconventional behaviour was to consider the set of previously-unselected droids becoming selected, and
    report the size of the set plus the size of the set of types of droids in the set.
    
    Iff there was exactly one droid of each type previously selected, and there was at least one unselected droid of
    each selected type, then the reported unit count would coincidentally be correct.
    
    Fixes ticket:3479.
    Cyp committed May 21, 2012
    Configuration menu
    Copy the full SHA
    22799c2 View commit details
    Browse the repository at this point in the history
  8. Show "[PlayerName] has left the game." to all players again.

    Fixes ticket:3461.
    Cyp committed May 21, 2012
    Configuration menu
    Copy the full SHA
    00b1968 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2012

  1. Update zlib to 1.2.7.

    dak180 committed May 22, 2012
    Configuration menu
    Copy the full SHA
    15aebc4 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2012

  1. Configuration menu
    Copy the full SHA
    5d19904 View commit details
    Browse the repository at this point in the history
  2. Let CB sensors defend allies too.

    Cyp committed May 23, 2012
    Configuration menu
    Copy the full SHA
    313738e View commit details
    Browse the repository at this point in the history

Commits on May 24, 2012

  1. Only play ID_SOUND_ARTIFACT_RECOVERED to the player picking up the ar…

    …tefact.
    
    Fixes ticket:3488.
    Cyp committed May 24, 2012
    Configuration menu
    Copy the full SHA
    acaf462 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2012

  1. Merge branch 'bugfixes' into 3.1

    automerge authored and cybersphinx committed May 25, 2012
    Configuration menu
    Copy the full SHA
    ddb696c View commit details
    Browse the repository at this point in the history

Commits on May 28, 2012

  1. Merge branch 'bugfixes' into 3.1

    automerge authored and cybersphinx committed May 28, 2012
    Configuration menu
    Copy the full SHA
    2738fe8 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2012

  1. Make sockets nonblocking as workaround for socket calls unexpectedly …

    …blocking.
    
    For some weird reason, select() sometimes returns that a socket write would not block, but the socket write does
    block, anyway.
    
    On display in the bottom of a locked manpage for select(), stuck in a disused lavatory with a sign on the door
    saying "Beware of the Leopard":
    BUGS
           Under Linux, select() may report a socket file descriptor as "ready for reading", while nevertheless a
           subsequent read blocks. This could for example happen when data has arrived but upon examination has wrong
           checksum and is discarded. There may be other circumstances in which a file descriptor is spuriously
           reported as ready. Thus it may be safer to use O_NONBLOCK on sockets that should not block.
    
    This would explain a socket read unexpectedly blocking, although the issue is actually a socket write unexpectedly
    blocking.
    
    Fixes ticket:3410, or else.
    Cyp committed May 30, 2012
    Configuration menu
    Copy the full SHA
    53ce0a7 View commit details
    Browse the repository at this point in the history
  2. Fix game mechanics bug allowing one truck to claim 10 derricks at once.

    Abandoned structures with no cost now slowly deconstruct over a period of one minute.
    Cyp committed May 30, 2012
    Configuration menu
    Copy the full SHA
    5ba90fe View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2012

  1. Fix commander unit count on loading games.

    Add error sound, and text when you can't add any more units to the Commander.
    
    Fixes ticket:3513
    Fixes ticket:3062
    vexed committed Jun 1, 2012
    Configuration menu
    Copy the full SHA
    b3f3b08 View commit details
    Browse the repository at this point in the history
  2. Add a work around and a assert to help out with the savegame issues d…

    …escribed in said ticket.
    
    Close ticket #3154
    vexed committed Jun 1, 2012
    Configuration menu
    Copy the full SHA
    20f203e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3334b4d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'bugfixes' into 3.1

    automerge authored and cybersphinx committed Jun 1, 2012
    Configuration menu
    Copy the full SHA
    f996fa0 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2012

  1. Assert on cyclic research dependencies instead of doing an infinite l…

    …oop.
    
    Spurious assertions are possible in the case that the research tree is excessively interconnected, such as
    researches 31-40 all depending on all of researches 21-30, and researches 21-30 all depending on all researches
    11-20, and so on. Although it probably shouldn't assert on excessively interconnected research trees, the loop as
    written could take a ridiculously long time, anyway.
    Cyp committed Jun 2, 2012
    Configuration menu
    Copy the full SHA
    4079ff2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    113796a View commit details
    Browse the repository at this point in the history
  3. Update translations.

    cybersphinx committed Jun 2, 2012
    Configuration menu
    Copy the full SHA
    b6c77bd View commit details
    Browse the repository at this point in the history
  4. Increase precision of sorting in generate-statistics-html.py.

    Fix by Emdek, closes #3519.
    
    Also remove unneeded "import os".
    cybersphinx committed Jun 2, 2012
    Configuration menu
    Copy the full SHA
    2228e80 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2012

  1. Configuration menu
    Copy the full SHA
    e0939a0 View commit details
    Browse the repository at this point in the history
  2. Don't use bsocket and tcp_socket at the same time.

    Somehow fixes a client crash when failing to join a game. Possibly caused by deleting one of bsocket or tcp_socket,
    and then using the other.
    Cyp committed Jun 3, 2012
    Configuration menu
    Copy the full SHA
    bf2483c View commit details
    Browse the repository at this point in the history
  3. Don't continue to wait for a NET_ACCEPTED after processing a NET_REJE…

    …CTED.
    
    Don't wait for a NET_ACCEPTED after the socket is broken, either.
    Cyp committed Jun 3, 2012
    Configuration menu
    Copy the full SHA
    4d658c9 View commit details
    Browse the repository at this point in the history
  4. Fix host crash on failure in NET_CreatePlayer().

    NET_CreatePlayer() should not be able to fail here, though. See following commit.
    
    Crash was due to treating ERROR_FULL == 2 as an uint8_t pointer, and trying to dereference it.
    Cyp committed Jun 3, 2012
    Configuration menu
    Copy the full SHA
    7a0cd2e View commit details
    Browse the repository at this point in the history
  5. Fix joining games with some closed slots.

    Although it no longer crashed when trying to join a game with some closed slots (see previous commits), it is also
    desirable to actually be able to join it.
    Cyp committed Jun 3, 2012
    Configuration menu
    Copy the full SHA
    7816f9f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2012

  1. Merge branch 'bugfixes' into 3.1

    automerge authored and cybersphinx committed Jun 4, 2012
    Configuration menu
    Copy the full SHA
    49d60d4 View commit details
    Browse the repository at this point in the history
  2. Do not return client broadcast messages to the sender.

    Instead of sending a copy of broadcast messages back to the sender, which ignores them anyway, save the bandwidth.
    Cyp committed Jun 4, 2012
    Configuration menu
    Copy the full SHA
    58551ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    051f83c View commit details
    Browse the repository at this point in the history
  4. Simplify NETrecvGame() slightly.

    No need to check for NET_* messages in game queues.
    Cyp committed Jun 4, 2012
    Configuration menu
    Copy the full SHA
    6af88a6 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2012

  1. Don't desynch on dropped players.

    Desynch was due to host-spoofed GAME_PLAYER_LEFT message being processed by clients at random times.
    
    Instead of putting the GAME_PLAYER_LEFT in a NET_SHARE_GAME_QUEUE, put the GAME_PLAYER_LEFT in a NET_SHARE_GAME_QUEUE
    in a NET_SEND_TO_PLAYER, such that the clients' NETrecvNet() will process the GAME_PLAYER_LEFT in the same iteration
    of the for (current = 0; current < MAX_CONNECTED_PLAYERS; ++current) loop as the real GAME_* messages from that
    player, and therefore not mix up the messages.
    
    To reproduce before this commit, start 8-or-so clients, set all to debug mode, change game speed of some clients
    slightly, start kicking players. Keep trying again, until desynch is reproduced. Changing game speed of some clients
    might or might not be required.
    
    See 93f0e61.
    Cyp committed Jun 5, 2012
    Configuration menu
    Copy the full SHA
    35f301b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c346e9e View commit details
    Browse the repository at this point in the history
  3. Use a faster optipng option set that also strips metadata.

    Requires optipng 0.7.1+ to work.
    dak180 committed Jun 5, 2012
    Configuration menu
    Copy the full SHA
    fbd757b View commit details
    Browse the repository at this point in the history
  4. Allow queuing building on burning oil wells.

    Actual construction only starts after the oil well finishes burning.
    Cyp committed Jun 5, 2012
    Configuration menu
    Copy the full SHA
    353357b View commit details
    Browse the repository at this point in the history
  5. Add oil barrels to map preview.

    Cyp committed Jun 5, 2012
    Configuration menu
    Copy the full SHA
    5b07a7b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    27dfe97 View commit details
    Browse the repository at this point in the history
  7. Fix CB fire against mobile targets.

    Steps to reproduce:
    1) Player A builds a CB sensor.
    2) Player B attacks the CB sensor with a mortar borg.
    3) Player B runs away with the mortar borg where player A can't see.
    4) Player A builds artillery.
    5) Player B slowly kills off all the artillery with an MG viper wheels tank, while the artillery just sits there
       pointing at the mortar borg without firing.
    
    To trigger, the artillery must be built after the last CB sensor in range of where the mortar borg attacks. Any
    type of mobile artillery can trigger the bug, such as archangel leopard tracks, or MRA dragon wheels.
    
    Workaround: Player A can build an uplink, so that the mortar borg becomes visible, and the artillery fires. If
                there's still anything left of the artillery by the time the uplink is built, that is.
    
    Fixes ticket:3529.
    Cyp committed Jun 5, 2012
    Configuration menu
    Copy the full SHA
    193eba2 View commit details
    Browse the repository at this point in the history
  8. Fix .gitignore.

    The tools/image/image in .gitignore was mysteriously changed to be a directory only in
    c346e9e, and the file therefore fails to be ignored.
    Cyp committed Jun 5, 2012
    Configuration menu
    Copy the full SHA
    c94112b View commit details
    Browse the repository at this point in the history