Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shooting through walls #271

Closed
vexed opened this issue Mar 24, 2019 · 6 comments

Comments

@vexed
Copy link
Member

commented Mar 24, 2019

Obviously, we shouldn't allow units to shoot through walls.

Broken in f965d77

Needless to say, this is a blocker.

@vexed vexed added the Blocker label Mar 24, 2019

@WZ2100ModsFan

This comment has been minimized.

Copy link

commented Mar 24, 2019

Now I've realized the walls are not meant to be penetrate through.

@past-due past-due added the Bug label Mar 27, 2019

@past-due past-due added this to the 3.3.0_GM milestone Mar 27, 2019

@Prime-Kosh

This comment has been minimized.

Copy link

commented Apr 8, 2019

This is a very glaring bug!

@KJeff01 KJeff01 changed the title Shooting through walls (regression) Shooting through walls Apr 25, 2019

@KJeff01 KJeff01 added the Regression label Apr 25, 2019

KJeff01 added a commit to KJeff01/warzone2100 that referenced this issue Apr 27, 2019
KJeff01 added a commit to KJeff01/warzone2100 that referenced this issue Apr 27, 2019
Try making good unit behavior when walls block a target.
Rough attempt to get units to stop firing through walls while
also trying to path towards their target without an obstructed view
of them.

Fixes Warzone2100#271
@Iluvalar

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Please, if this bug appeared again, it's good sign.
Somewhere in that code, there should be a place where there bullets that were meant to miss the target go through the units. LEAVE THAT ON if it'S a droid, it's intended this way.

@KJeff01

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

AFAIK, projectiles hit enemy droids if they touch them and has been like that for a while I assume.

@Iluvalar

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

Its fine if they hit the droids, as long as the shot was not intended to miss by the code. There is a "dice" roll for the accuracy in the code. If the shot was identified to be a miss on a given target, the engine should not be allowed to fail the miss and end up hitting.

Read the other ticket I made about this.

KJeff01 added a commit that referenced this issue May 9, 2019

@KJeff01 KJeff01 closed this in 5cbe6b9 May 9, 2019

@Berg53

This comment has been minimized.

Copy link

commented May 10, 2019

Thanks kjeff01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.