Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
What is the point of PIE version? #325
According to https://github.com/Warzone2100/warzone2100/blob/master/doc/PIE.md there are multiple PIE 3-only directives.
Yet there are multiple models in master with EVENTS and ANIMOBJECT directives which are still PIE 2.
ImdLoader is simply checking for 2 or 3 in version and not using this info for anything else (maybe passes down for points reading):
Could you please clarify this situation? Should other editors support all directives for both PIE 2 and 3, since this is actual logic in wz since probably 2.x? With floating points being the only difference between them.
Editors should support the status quo rather than unimplemented specs.
Unlike you, I misunderstood the differences between PIE 2 and PIE 3
Judging from http://developer.wz2100.net/wiki/PIE_format?action=history
Since bc80e9b only coordinate notation
My mistake should be rectified with #334.
Thank you for looking into this.
Wow, I'm so not sure if that ancient comment is to blame for stale pies :) I think that commit was necessary so that models could be opened with tools that we had at the time, but there were no intent not to keep it in old format per se.
My speculation is that the current intent is to keep int-based PIE due to MP needs, thus PIE2 only models in vanilla wz. If that is really the case, then it would be nice to put a note somewhere and maybe retire PIE3 too. This way mods artwork can be exported into more future proof format.
Together with c1beb1f, this commit
Could you be more specific? I'm not sure I understand what you mean.
In af9c913, Per wrote:
This suggests that PIE 3 is supposed to be used for newer models.
Art Revolution Mod (recent version):
Source code repository, latest revision:
I did not realize that there are actual PIE 3 models in master... I happen to open all those animated ones recently and they were all PIE 2.
I think the real question is: why there is still a PIE 2 format? Do you guys know of any good reasons to keep it supported on top of PIE 3 still? I don't have up-to-date insight into that question, unfortunately...
Again, it does not look like there is much extra code, but it is still has to be supported for lifecycle of each release branch. Plus, practical implications are that if there is some technical reason to keep PIE 2 as base format, than that has to be spelled somewhere, so any future developments will accommodate those...
Our source code contains PIE 2 models because no one converted them.