Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix cb1252cd7 (Change calculation of reticule button coordinates) #262

Merged
merged 1 commit into from Mar 13, 2019

Conversation

@past-due
Copy link
Contributor

commented Mar 13, 2019

Commit cb1252c results in reticule buttons that are aligned incorrectly (ex. overtly shifted to the right)

This attempts to fix the offsets (based on the values of ReticuleOffsets prior to cb1252c, and then
incorporating the changes to intfac.img in cb1252c)

…ates)

Commit cb1252c results in reticule buttons that are aligned incorrectly (ex. overtly shifted to the right)

This attempts to fix the offsets (based on the values of ReticuleOffsets prior to cb1252c, and then
incorporating the changes to intfac.img in cb1252c)
@KJeff01

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Looks centered enough to me.

@past-due past-due merged commit 6731c4c into Warzone2100:master Mar 13, 2019
7 of 8 checks passed
7 of 8 checks passed
LGTM analysis: C/C++ Running analyses for revisions
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
@past-due past-due deleted the past-due:2019_03_13_fix_reticule_1 branch Mar 13, 2019
@past-due past-due added this to the 3.3.0_beta2 milestone Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.