Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reticule button hit-testing / click area #264

Merged

Conversation

@past-due
Copy link
Contributor

commented Mar 16, 2019

The hit-testing for the reticule buttons has not been ideal, but it worsened after commit cb1252c (and the attempt to fix the visual offsets in commit 6731c4c). The hit-test boxes were wrong, and it made the buttons much harder to click.

This implements custom hit-testing behavior based on the image dimensions (and a bounding ellipse based on those dimensions that much more accurately reflects the actual shape of the button images).

@past-due past-due changed the title Improve reticule button hit-testing Improve reticule button hit-testing / click area Mar 16, 2019

@past-due past-due force-pushed the past-due:2019_03_16_reticule_hit_testing_1 branch from 58a2811 to cbec029 Mar 16, 2019

past-due added 2 commits Mar 16, 2019
Improve reticule button hit-testing
The hit-testing for the reticule buttons has not been ideal, but it worsened after commit cb1252c (and the attempt to fix the visual coordinates in commit 6731c4c). The hit-test boxes were wrong, and it made the buttons much harder to click.

This implements custom hit-testing behavior based on the image dimensions (and a bounding ellipse based on those dimensions that much more accurately reflects the actual shape of the button images).

@past-due past-due force-pushed the past-due:2019_03_16_reticule_hit_testing_1 branch from cbec029 to 7ad1bf4 Mar 17, 2019

@past-due past-due merged commit 9394cd5 into Warzone2100:master Mar 17, 2019

8 checks passed

LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@past-due past-due deleted the past-due:2019_03_16_reticule_hit_testing_1 branch Mar 17, 2019

@past-due past-due added this to the 3.3.0_beta2 milestone Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.