Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mission.apsDroidLists transporter count check #277

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@KJeff01
Copy link
Contributor

commented Mar 26, 2019

In the scenario a player's first transport load does not contain any trucks in Gamma-1, and said player tries to bring in all their trucks from the transporter menu, the mission will instantly fail.

Compound this with the transporter loads getting mixed up if loading saves from Beta-end and we essentially come across a potential soft-lock.

Campaign library function __camPlayerDead() checks if a player is dead by seeing if there are no factories or trucks. Specifically, countDroid(DROID_CONSTRUCT) is returning zero. Thus the player is not considered alive.

So, this PR updates the counts for trucks and commanders that are inside a transporter inside the mission list. Below is a savegame to reproduce this issue.

gamma-fail.zip

@past-due past-due added this to the 3.3.0_beta2 milestone Mar 27, 2019

@KJeff01 KJeff01 merged commit e2dc5d7 into Warzone2100:master Mar 27, 2019

8 checks passed

LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@KJeff01 KJeff01 deleted the KJeff01:countFix branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.