Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotated structure shadows #285

Merged

Conversation

@past-due
Copy link
Contributor

commented Mar 30, 2019

Since structures can be rotated, they must use pie_SHADOW instead of pie_STATIC_SHADOW.

(Note: Because of the new ShadowCache (see: piedraw.cpp), it's not clear whether there's much of a use for pie_STATIC_SHADOW anymore - but this is the minimal change that fixes the rotated structure shadow issue. In the future, maybe reconsider whether pie_STATIC_SHADOW is needed in the few remaining places it's used.)

Resolves #284

@past-due past-due added this to the 3.3.0_beta2 milestone Mar 30, 2019

@past-due past-due merged commit b7e0061 into Warzone2100:master Mar 30, 2019

8 checks passed

LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@past-due past-due deleted the past-due:2019_03_30_fix_structure_shadow_1 branch Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.