Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

challenge.cpp fixes #299

Merged
merged 2 commits into from Apr 5, 2019

Conversation

@past-due
Copy link
Contributor

commented Apr 4, 2019

  • Replace use of QTime in challenge.cpp
  • Split challenge mouse-over tip into multiple lines
    • Previously, at smaller window / resolution sizes, portions of the tooltip could be cut off.
@Forgon2100

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

* Replace use of `QTime` in challenge.cpp

* Split challenge mouse-over tip into multiple lines
  
  * Previously, at smaller window / resolution sizes, portions of the tooltip could be cut off.

Contains a mistake, unless the first tooltip line should really end in a dot.
Could you limit this pull request to the first commit?

@past-due

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

Contains a mistake, unless the first tooltip line should really end in a dot.

Later lines (from the description) end in punctuation, so this seems appropriate.

@past-due past-due merged commit 2cc667c into Warzone2100:master Apr 5, 2019

8 checks passed

LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@past-due past-due deleted the past-due:2019_03_30_replace_qtime_1 branch Apr 5, 2019

@past-due past-due added this to the 3.3.0_beta2 milestone Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.