Replace legacy Carbon dialogs with Cocoa NSAlerts #3

2 commits merged into from Dec 11, 2010


None yet
2 participants

nanotech commented Dec 11, 2010

They're 64-bit compatible now.

This also updates the libpng download url; they renamed a folder.


dak180 commented Dec 11, 2010

This was very nice; you should hang out in #warzone2100-dev if you are interested in doing more work on wz (there is always more work) ☺

@dak180 dak180 pushed a commit to dak180/warzone2100 that referenced this pull request Jul 4, 2011

Rene Jochum Merge pull request #3 from dak180/topic/bson
Merge branch 'master' into topic/bson

@Cyp Cyp added a commit that referenced this pull request Jul 8, 2016

@Cyp Cyp Fix crash.
Happend when saving and then loading a campaign game. Probably due to a left-over pointer.

==29775==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61a0007842a8 at pc 0x694d8b bp 0x7ffed01f3700 sp 0x7ffed01f36f0
READ of size 4 at 0x61a0007842a8 thread T0
    #0 0x694d8a in hciUpdate() ../../src/hci.cpp:1113
    #1 0x740494 in gameStateUpdate ../../src/loop.cpp:668
    #2 0x740494 in gameLoop() ../../src/loop.cpp:707
    #3 0x745b37 in runGameLoop ../../src/main.cpp:886
    #4 0x745b37 in mainLoop() ../../src/main.cpp:992
    #5 0xe03152 in WzMainWindow::paintGL() ../../../lib/qtgame/wzapp_qt.cpp:285

AddressSanitizer can not describe address in more detail (wild memory access suspected).
SUMMARY: AddressSanitizer: heap-buffer-overflow ../../src/hci.cpp:1113 hciUpdate()

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment