Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Nullbot fixes and improvements #313

Merged
merged 7 commits into from Apr 10, 2019

Conversation

@KJeff01
Copy link
Contributor

commented Apr 8, 2019

Most important is to not allow Nullbot owned VTOLs to chase enemy VTOLs that they can't hit as described in #283.

KJeff01 added 7 commits Mar 29, 2019
Nullbot VTOL fixes.
- Fix vtolCanHit() to properly identify a droid. This caused it to always check if
the potential VTOL could hit grounded objects only.

- Add more checks to not let Nullbot's VTOLs chase after enemy VTOLs that they can't
really attack.
Fix Nullbot function vtolArmed().
Was ignoring all specified armed percentage amounts.
Nullbot research improvements.
- Include path extras since they are otherwise never used.
- Don't include engine upgrades for cannon extras since that
makes it focus too much on body, armor, and engine upgrades.

@past-due past-due added this to the 3.3.0_beta2 milestone Apr 8, 2019

@KJeff01 KJeff01 merged commit 7970931 into Warzone2100:master Apr 10, 2019

8 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@KJeff01 KJeff01 deleted the KJeff01:nb branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.