Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign script improvements. #320

Merged
merged 6 commits into from Apr 10, 2019

Conversation

@KJeff01
Copy link
Contributor

commented Apr 9, 2019

Includes a nice set of mission script cleanups plus a fix for library function __camPlayerDead() not recognizing the player isn't alive on timeout missions (the one and only Beta-end).

KJeff01 added 6 commits Nov 3, 2018
Originally, the script had individual time and audio arrays for missile launch/detonation.
This was unnecessary and a more sane approach can be used in its place.
For missions that allow reinforcements as soon as the first
transporter exits the map.
Missions like Beta-end would continue until timer timeout if everything
the player owned was destroyed while having sent off at least 1 truck
during the mission. Now, fail instantly.
Just require one transporter load.
@past-due past-due added this to the 3.3.0_beta2 milestone Apr 9, 2019
@KJeff01 KJeff01 merged commit 9d1fc6f into Warzone2100:master Apr 10, 2019
8 checks passed
8 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
@Forgon2100

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Please update doc/js-campaign.md because these patches changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.