Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update German translation #326

Merged
merged 1 commit into from Apr 16, 2019

Conversation

@kreuvf
Copy link
Contributor

commented Apr 16, 2019

This commit contains some comments for future translators. This information would be best kept in an extra file so to not clutter the de.po. Looking forward to what Crowdin can do in this regard.

@past-due past-due added this to the 3.3.0_beta2 milestone Apr 16, 2019

@Cyp Cyp merged commit 4b2a947 into Warzone2100:master Apr 16, 2019

8 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
@Forgon2100

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

This commit contains some comments for future translators. This information would be best kept in an extra file so to not clutter the de.po. Looking forward to what Crowdin can do in this regard.

The more translator comments we have, the better.
They can stay in the PO file as far as I'm concerned.
Whether to move them to Crowdin is up to you, of course.

Perhaps all comments could be written in German.
Quoting people is unnecessary, and thus many could be more concise.

If this commit is exhaustive, a few changes require further work.
I have created #328 to correct all mistakes I noticed, listed below:

"Safe haven" has been re-translated in all instances except one:

msgid "You are to start the immediate evacuation of Beta Base to the safe haven."
msgstr "Beginnen Sie sofort damit die Betabasis in die Sicherheitszone zu evakuieren."

The gender of the noun "Mod" is generally feminine, yet masculine in:

msgid "You have an incompatible mod."
msgstr "Sie haben einen inkompatiblen Mod."

msgid "%s (%u) has an incompatible mod, and has been kicked."
msgstr "%s (%u) hat einen inkompatiblen Mod und wurde rausgeschmissen."

To comply with ticket:4872, the following change should be applied:

- msgid "%s - %u Unit assigned - Damage %3.0f%%"
+ msgid "%s - %u Unit assigned - Damage %d/%d"

Kreuvf's repository contains a discussion of the changes in this commit,
in PR 1 at kreuvf#1 for the branch
de.po-2019-03-31.
My suggestions that were rejected in ticket:4845 were not debated (cf.
http://developer.wz2100.net/attachment/ticket/4845/de.po-4845-01-rejected.patch
), yet the following should have been:

# The plural of "scavengers" is "Scavenger" in all other instances
msgid "Defeat the scavengers and retrieve any artifacts."
- msgstr "Vernichten Sie die Scavengers und bergen Sie alle Artefakte."
+ msgstr "Vernichten Sie die Scavenger und bergen Sie alle Artefakte."

# The current translation confuses "proximity" with "approximation".
# Note that the weapon is a suicide bomber.

msgid "Proximity Bomb Turret"
- msgstr "Näherungsbombenabwurfschacht"
+ msgstr "Selbstmordkommando-Bombenturm"

msgid "Proximity Superbomb Turret"
- msgstr "Näherungssuperbombenabwurfschacht"
+ msgstr "Selbstmordkommando-Superbombenturm"

msgid "New Proximity Bomb Turret Available"
- msgstr "Neuer Näherungsbombenabwurfschacht verfügbar"
+ msgstr "Neuer Selbstmordkommando-Bombenturm verfügbar"

# This research item is supposed to enable targeting for sensors
msgid "Sensor Lock"
- msgstr "Sensorsperre"
+ msgstr "Zielbestimmung für Sensoren"

# "Graphics Options->Radar" setting
msgid "Fixed"
- msgstr "Fest"
+ msgstr "Unbeweglich"

# "Graphics Options->Radar Jump" setting

msgid "Instant"
- msgstr "Sofort"
+ msgstr "Verzögerungsfrei"

msgid "Tracked"
- msgstr "Sanft"
+ msgstr "Langsam verfolgt"

msgid "Radar Jump"
- msgstr "Minikartensprung"
+ msgstr "Minikartenortsauswahl"
@highlander1599

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

In the discussion between Kreuvf and me, we agreed to replace "Geschütz" by "Kanone" because "Geschütz" is a generic term that includes Cannons, Howitzers and Mortars (https://de.wikipedia.org/wiki/Gesch%C3%BCtz). I agreed to do this work and will also include the terms you found that we overlooked.

># The plural of "scavengers" is "Scavenger" in all other instances
>msgid "Defeat the scavengers and retrieve any artifacts."
>- msgstr "Vernichten Sie die Scavengers und bergen Sie alle Artefakte."
>+ msgstr "Vernichten Sie die Scavenger und bergen Sie alle Artefakte."

I see this similar to the word "Espresso". We adopt the word into German but are using the original plural. In this example "Zwei Espressi" instead of "Zwei Espressos". I will change "Scavenger" into "Scavengers" whereever necessary.

># The current translation confuses "proximity" with "approximation".
># Note that the weapon is a suicide bomber.

>msgid "Proximity Bomb Turret"
>- msgstr "Näherungsbombenabwurfschacht"
>+ msgstr "Selbstmordkommando-Bombenturm"

>msgid "Proximity Superbomb Turret"
>- msgstr "Näherungssuperbombenabwurfschacht"
>+ msgstr "Selbstmordkommando-Superbombenturm"

>msgid "New Proximity Bomb Turret Available"
>- msgstr "Neuer Näherungsbombenabwurfschacht verfügbar"
>+ msgstr "Neuer Selbstmordkommando-Bombenturm verfügbar"

You wrote in one of your translator comments that this is a weapon only used in demos from 1999. Also see: http://forums.wz2100.net/viewtopic.php?f=6&t=4961&hilit=proximity&start=45#p50361 So I'm more of the opinion that this unnecessary term should rather be removed from the original source.

`># This research item is supposed to enable targeting for sensors
>msgid "Sensor Lock"
>- msgstr "Sensorsperre"
>+ msgstr "Zielbestimmung für Sensoren"`

The correct translation for "Sensor Lock" is "Sensorsperre". If this feature is not working that way change first the wrong description in the original source.

># "Graphics Options->Radar" setting
>msgid "Fixed"
>- msgstr "Fest"
>+ msgstr "Unbeweglich"

># "Graphics Options->Radar Jump" setting

>msgid "Instant"
>- msgstr "Sofort"
>+ msgstr "Verzögerungsfrei"

>msgid "Tracked"
>- msgstr "Sanft"
>+ msgstr "Langsam verfolgt"

>msgid "Radar Jump"
>- msgstr "Minikartensprung"
>+ msgstr "Minikartenortsauswahl"

These terms weren't discussed because Kreuvf rejected them and I accepted his decision. Nevertheless I will include them again into my changes and invite you to be again part of the discussion. Use this opportunity to convince Kreuvf from your ideas. If you still don't want to discuss with us don't be surprised why Kreuvf and I don't discuss things that are decided in our eyes.

Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 16, 2019
Update German translation
* consistently translate:
  * "save haven" as "sicherer Hafen"
  * "mod" as noun with feminine gender
  * "scavengers" as "Scavenger"

* improve translation of "Radar" and "Radar Jump" settings in
  "Graphics Options" screen

* fix format specifier to comply with ticket:4872

* fix translations of unused technologies:
  * "proximity bomb" is suicide bomber (only used in demos from 1999)
  * "sensor lock" enables targeting for sensors (unimplemented)

Refs ticket:4845
Refs Warzone2100#326
Fixes Warzone2100#328

@kreuvf kreuvf deleted the kreuvf:de.po-2019-04-16 branch Apr 18, 2019

Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 18, 2019
Update German translation
* consistently translate:
  * "save haven" as "sicherer Hafen"
  * "mod" as noun with feminine gender
  * "scavengers" as "Scavenger"

* fix format specifier to comply with ticket:4872

* fix translations of unused technologies:
  * a "proximity bomb" is a suicidal bomb (only used in demos from 1999)
  * "sensor lock" enables targeting for sensors (unimplemented)

Refs ticket:4845
Refs Warzone2100#326
Fixes Warzone2100#328
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 23, 2019
Update German translation
* consistently translate:
  * "save haven" as "sicherer Hafen"
  * "mod" as noun with feminine gender
  * "scavengers" as "Scavenger"

* fix format specifier to comply with ticket:4872

* fix translations of unused technologies:
  * a "proximity bomb" is a suicidal bomb (only used in demos from 1999)
  * "sensor lock" enables targeting for sensors (unimplemented)

Refs ticket:4845
Refs Warzone2100#326
Fixes Warzone2100#328
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 23, 2019
Change German translation of cannons and rail guns
* classify cannons, rail guns and the EMP cannon as "Kanone" instead of
  "Geschütz", a less specific term that includes mortars and howitzers
* in Warzone2100#326, all flak weapons had been re-translated as "Flugabwehrkanone"
  (replacing the term "Flugabwehrgeschütz") to match the acronym "FLAK"
  as part of 4b2a947

Refs Warzone2100#326
Fixes Warzone2100#328

Co-authored-by: highlander1599 <highlander1599@gmail.com>
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 24, 2019
Change German translation of cannons and rail guns
* classify cannons, rail guns and the EMP cannon as "Kanone" instead of
  "Geschütz", a less specific term that includes mortars and howitzers
* in Warzone2100#326, all flak weapons had been re-translated as "Flugabwehrkanone"
  (replacing the term "Flugabwehrgeschütz") to match the acronym "FLAK"
  as part of 4b2a947

Refs Warzone2100#326
Fixes Warzone2100#328

Co-authored-by: highlander1599 <highlander1599@gmail.com>
Co-authored-by: kreuvf <kreuvf@users.noreply.github.com>
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 25, 2019
Update German translation
* consistently translate:
  * "save haven" as "sicherer Hafen"
  * "mod" as noun with feminine gender
  * "scavengers" as "Scavenger"
  * "superhot gel" as "Gel für sehr hohe Temperaturen"
  * "super XYZ cyborg" as "XYZ-Supercyborg"

* fix format specifier to comply with ticket:4872

* fix translations of unused technologies:
  * a "proximity bomb" is a suicidal bomb (only used in demos from 1999)
  * "sensor lock" enables targeting for sensors (unimplemented)

Refs ticket:4845
Refs Warzone2100#326
Fixes Warzone2100#328
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 25, 2019
Change German translation of cannons and rail guns
* classify cannons, rail guns and the EMP cannon as "Kanone" instead of
  "Geschütz", a less specific term that includes mortars and howitzers
* in Warzone2100#326, all flak weapons had been re-translated as "Flugabwehrkanone"
  (replacing the term "Flugabwehrgeschütz") to match the acronym "FLAK"
  as part of 4b2a947

Refs Warzone2100#326
Fixes Warzone2100#328

Co-authored-by: highlander1599 <highlander1599@gmail.com>
Co-authored-by: kreuvf <kreuvf@users.noreply.github.com>
past-due added a commit that referenced this pull request Jun 13, 2019
Update German translation
* consistently translate:
  * "save haven" as "sicherer Hafen"
  * "mod" as noun with feminine gender
  * "scavengers" as "Scavenger"
  * "superhot gel" as "Gel für sehr hohe Temperaturen"
  * "super XYZ cyborg" as "XYZ-Supercyborg"

* fix format specifier to comply with ticket:4872

* fix translations of unused technologies:
  * a "proximity bomb" is a suicidal bomb (only used in demos from 1999)
  * "sensor lock" enables targeting for sensors (unimplemented)

Refs ticket:4845
Refs #326
Fixes #328
past-due added a commit that referenced this pull request Jun 13, 2019
Change German translation of cannons and rail guns
* classify cannons, rail guns and the EMP cannon as "Kanone" instead of
  "Geschütz", a less specific term that includes mortars and howitzers
* in #326, all flak weapons had been re-translated as "Flugabwehrkanone"
  (replacing the term "Flugabwehrgeschütz") to match the acronym "FLAK"
  as part of 4b2a947

Refs #326
Fixes #328

Co-authored-by: highlander1599 <highlander1599@gmail.com>
Co-authored-by: kreuvf <kreuvf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.