Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change console messages for production limits #329

Merged
merged 2 commits into from Apr 25, 2019

Conversation

@Forgon2100
Copy link
Contributor

commented Apr 18, 2019

  • add console message informing about missing Command Relay Center
    if this prevents commander production (suggested in #327 by spikebike)
  • remove delay of 40 seconds before showing first console message
    about exceeded manufacturing limits (ending in "Production Halted")
Commander units cannot be produced
* without a Command Relay Center
* when owning no less than 10 commanders

More precise console messages distinguish between these causes.

Refs ticket:1661
Fixes #327
Fixes #329

Co-authored-by: spikebike <spikebike@users.noreply.github.com>
@past-due past-due added this to the 3.3.0_beta2 milestone Apr 18, 2019
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 18, 2019
@Forgon2100 Forgon2100 force-pushed the Forgon2100:production_halted branch from 3ac81a7 to 02bb690 Apr 18, 2019
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 18, 2019
The first console message informing users about manufacturing limits,
familiar from its ending "Production Halted", was shown 40 seconds late
(the amount of MAX_UNIT_MESSAGE_PAUSE in human-readable time).

Refs ticket:4446
Refs Warzone2100#327
Fixes Warzone2100#329
The first console message informing users about manufacturing limits,
familiar from its ending "Production Halted", was shown 40 seconds late
(the amount of MAX_UNIT_MESSAGE_PAUSE in human-readable time).

Refs ticket:4446
Refs #327
Fixes #329
@Forgon2100 Forgon2100 force-pushed the Forgon2100:production_halted branch from 02bb690 to 2a5ee09 Apr 18, 2019
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 23, 2019
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 24, 2019
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Apr 25, 2019
@KJeff01 KJeff01 merged commit 3bb244b into Warzone2100:master Apr 25, 2019
8 checks passed
8 checks passed
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
KJeff01 added a commit that referenced this pull request Apr 25, 2019
Commander units cannot be produced
* without a Command Relay Center
* when owning no less than 10 commanders

More precise console messages distinguish between these causes.

Refs ticket:1661
Fixes #327
Fixes #329

Co-authored-by: spikebike <spikebike@users.noreply.github.com>
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jun 11, 2019
* add translation of structure limit screen title
* reinstate translation of hold, pursue and guard orders
* add translation of commander limit messages

Refs cac83e9
Refs ticket:4871
Refs Warzone2100#263
Refs Warzone2100#329
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jun 11, 2019
* add translation of structure limit screen title
* reinstate translation of hold, pursue and guard orders
* add translation of commander limit messages

Refs cac83e9
Refs ticket:4871
Refs Warzone2100#263
Refs Warzone2100#329
Fixes Warzone2100#377
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jun 11, 2019
* add translation of structure limit screen title
* reinstate translation of hold, pursue and guard orders
* add translation of commander limit messages

Refs cac83e9
Refs ticket:4871
Refs Warzone2100#263
Refs Warzone2100#329
Fixes Warzone2100#377
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jun 12, 2019
past-due added a commit that referenced this pull request Jun 13, 2019
KJeff01 added a commit that referenced this pull request Jun 13, 2019
* add translation of structure limit screen title
* reinstate translation of hold, pursue and guard orders
* add translation of commander limit messages

Refs cac83e9
Refs ticket:4871
Refs #263
Refs #329
Fixes #377
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jun 23, 2019
* remove unnecessary fuzzy flag
* add translation of structure limit screen title
* reinstate translation of hold, pursue and guard orders
* add translation of commander limit messages
* reinstate translation of range orders
* fix format specifiers in map transfer messages

Refs b00b17c
Refs ticket:4871
Refs Warzone2100#263
Refs Warzone2100#329
Refs Warzone2100#314
Refs Warzone2100#392
Fixes Warzone2100#402
past-due added a commit that referenced this pull request Jun 24, 2019
* remove unnecessary fuzzy flag
* add translation of structure limit screen title
* reinstate translation of hold, pursue and guard orders
* add translation of commander limit messages
* reinstate translation of range orders
* fix format specifiers in map transfer messages

Refs b00b17c
Refs ticket:4871
Refs #263
Refs #329
Refs #314
Refs #392
Fixes #402
vaut pushed a commit to vaut/warzone2100 that referenced this pull request Jun 27, 2019
KJeff01 added a commit that referenced this pull request Jun 27, 2019
Refs ticket:4872
Refs #263
Refs #329
Fixes #382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.