Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL backend] Use SDL_GL_SetSwapInterval #331

Merged
merged 1 commit into from Apr 20, 2019

Conversation

@past-due
Copy link
Contributor

commented Apr 19, 2019

Since WZ requires SDL 2, simplify the SDL backend code by utilizing SDL_GL_SetSwapInterval (available since SDL 2.0.0) - which provides better platform compatibility, and has additional workarounds for driver (and other) issues.

Because of the compatibility enhancements and driver bug workarounds available in the SDL_GL_SetSwapInterval implementations, this may help resolve vsync enabling / disabling issues on some systems.

@past-due past-due added this to the 3.3.0_beta2 milestone Apr 19, 2019

@past-due

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

This pull request fixes 1 alert when merging 35f6216 into b00b17c - view on LGTM.com

fixed alerts:

  • 1 for FIXME comment

Comment posted by LGTM.com

[SDL backend] Use SDL_GL_SetSwapInterval
Since WZ requires SDL 2, simplify the SDL backend code by utilizing `SDL_GL_SetSwapInterval` (available since SDL 2.0.0) - which provides better platform compatibility, and has additional workarounds for driver (and other) issues.

@past-due past-due force-pushed the past-due:2019_04_19_swapinterval_sdl_1 branch from 35f6216 to ab5dae6 Apr 20, 2019

@past-due

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2019

This pull request fixes 1 alert when merging ab5dae6 into b00b17c - view on LGTM.com

fixed alerts:

  • 1 for FIXME comment

Comment posted by LGTM.com

@past-due past-due merged commit d517b62 into Warzone2100:master Apr 20, 2019

8 checks passed

LGTM analysis: C/C++ 1 fixed alert
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@past-due past-due deleted the past-due:2019_04_19_swapinterval_sdl_1 branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.