Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of PIE 2 format #334

Merged
merged 1 commit into from Apr 26, 2019

Conversation

@Forgon2100
Copy link
Contributor

commented Apr 25, 2019

The file doc/PIE.md erroneously states that PIE 2 files cannot include all
directives available in PIE 3. As inodlite pointed out in #325, this is wrong.

I suspect that the distinction between PIE 2 and PIE 3 was blurred in
bc80e9b (assuming it was ever precise).
They only differ in their notation of texture coordinates.

Fix documentation of PIE 2 format
* PIE 2 files can include all extensions available in PIE 3 since
  bc80e9b
* coordinate notation is the only difference between the PIE versions

Thanks to inodlite for noticing the mistake.

Refs ticket:4769
Fixes #325
Fixes #334

@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone Apr 25, 2019

@KJeff01 KJeff01 merged commit 58e78a2 into Warzone2100:master Apr 26, 2019

8 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.