Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version string being printed in wrong language #344

Merged
merged 1 commit into from May 10, 2019

Conversation

@Forgon2100
Copy link
Contributor

commented Apr 29, 2019

Updating the version string each time before it gets printed prevents
it from being printed in the wrong language if the game language

  • differs from the system locale
  • is changed via the "Options" -> "Game Options" screen

The attached ZIP file contains

  • screenshots of the version string with a foreign language enabled
  • a shell script to generate them

@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone May 9, 2019

Fix version string being printed in wrong language
Updating the version string each time before it gets printed ensures it
is written in the correct language if the game's language
* differs from the system locale
* is changed via the "Options" -> "Game Options" screen

Fixes #344

@Forgon2100 Forgon2100 force-pushed the Forgon2100:version_string_language branch from 6b095a0 to 867d14d May 10, 2019

@KJeff01 KJeff01 merged commit 4236886 into Warzone2100:master May 10, 2019

6 of 8 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.