Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version string being printed in wrong language #344

Merged
merged 1 commit into from May 10, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -110,26 +110,26 @@ const char *version_getFormattedVersionString()
{
static char versionString[MAX_STR_LENGTH] = {'\0'};

if (versionString[0] == '\0')
{
// Compose the working copy state string
// Compose the working copy state string
#if (VCS_WC_MODIFIED)
const char *wc_state = _(" (modified locally)");
// TRANSLATORS: Printed when compiling with uncommitted changes
const char *wc_state = _(" (modified locally)");
#else
const char *wc_state = "";
const char *wc_state = "";
#endif
// Compose the build type string
// Compose the build type string
#ifdef DEBUG
const char *build_type = _(" - DEBUG");
// TRANSLATORS: Printed in Debug builds
const char *build_type = _(" - DEBUG");
#else
const char *build_type = "";
const char *build_type = "";
#endif
// Construct the version string
// TRANSLATORS: This string looks as follows when expanded.
// "Version: <version name/number>, <working copy state>,
// Built: <BUILD DATE><BUILD TYPE>"
snprintf(versionString, MAX_STR_LENGTH, _("Version: %s,%s Built: %s%s"), version_getVersionString(), wc_state, getCompileDate(), build_type);
}

// Construct the version string
// TRANSLATORS: This string looks as follows when expanded.
// "Version: <version name/number>, <working copy state>,
// Built: <BUILD DATE><BUILD TYPE>"
snprintf(versionString, MAX_STR_LENGTH, _("Version: %s,%s Built: %s%s"), version_getVersionString(), wc_state, getCompileDate(), build_type);

return versionString;
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.