Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integer overflow #356

Merged
merged 1 commit into from May 17, 2019

Conversation

@ScorrMorr
Copy link

commented May 12, 2019

fix integer overflow in geometry.cpp

warzone2100/src/geometry.cpp:106:51: runtime error: signed integer overflow: 979499 * -3338 cannot be represented in type 'int'
warzone2100/src/geometry.cpp:106:68: runtime error: signed integer overflow: -3300 * 939715 cannot be represented in type 'int'
ScorrMorr
@past-due

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

Thanks for these fixes, @ScorrMorr!

@past-due past-due added this to the 3.3.0_beta2 milestone May 12, 2019

@KJeff01 KJeff01 merged commit 43a34a8 into Warzone2100:master May 17, 2019

6 of 8 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.