Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more broken shadows on walls and some features #368

merged 2 commits into from May 27, 2019


Copy link

commented May 27, 2019

Building off of #285, these patches will fix broken shadows on rotated buildings/huts (good to test against the hydrofin map), and broken wall-corner shadows mostly seen with scavenger bases in the campaign.

These patches obsolete the last uses of pie_STATIC_SHADOW everywhere in the source.

KJeff01 added 2 commits Apr 27, 2019
Always use a dynamic shadow for walls.
Fixes rotated scavenger wall-corner shadows which were otherwise broken.

@KJeff01 KJeff01 changed the title Shadows Fix more broken shadows on walls and some features May 27, 2019

@past-due past-due added this to the 3.3.0_beta2 milestone May 27, 2019

@KJeff01 KJeff01 merged commit 33963b5 into Warzone2100:master May 27, 2019

6 of 8 checks passed

LGTM analysis: JavaScript No code changes detected
LGTM analysis: Python No code changes detected
LGTM analysis: C/C++ No new or fixed alerts
WIP Ready for review
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary

@KJeff01 KJeff01 deleted the KJeff01:shadows branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.