Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aligning readme with: https://forums.wz2100.net/viewtopic.php?f=1&t=1… #374

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
4 participants
@psypherium
Copy link
Contributor

commented Jun 4, 2019

@Forgon2100

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

References to Trac's bug tracker also exist in other files.

@psypherium

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Ah ok. I'll have a look around later on for other similar fixes to add to this commit.

Forgon2100 added some commits Jun 9, 2019

Update bug tracker URLs
Trac's bug tracker has been dropped in favor of GitHub's issue tracker.

Fixes #374
Remove Trac plugins to manage tickets
Since Trac's bug tracker was shut down, they are no longer needed.

Fixes #374
@Forgon2100

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Ah ok. I'll have a look around later on for other similar fixes to add to this commit.

No longer necessary, since my pull request corrects all other instances.
Please merge it into your branch so that we can progress.

Merge pull request #1 from Forgon2100/patch-1
Update documentation for GitHub and Trac
@Forgon2100

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@past-due:
You might want to update doc/Release.md if GitHub's issue tracker should
need any changes, e.g. new tags, upon each release.

@lgtm-com

This comment has been minimized.

Copy link

commented Jun 12, 2019

This pull request fixes 3 alerts when merging c7ffade into 7073993 - view on LGTM.com

fixed alerts:

  • 3 for Import of deprecated module
@Forgon2100

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

This pull request fixes 3 alerts when merging c7ffade into 7073993 - view on LGTM.com

fixed alerts:

* 3 for Import of deprecated module

Thank you. Who knew that removing code could be so productive?

@@ -528,7 +528,7 @@ void _debug(int line, code_part part, const char *function, const char *str, ...
#if defined(WZ_OS_WIN)
char wbuf[512];
ssprintf(wbuf, "%s\n\nPlease check the file (%s) in your configuration directory for more details. \
\nDo not forget to upload the %s file, WZdebuginfo.txt and the warzone2100.rpt files in your bug reports at http://developer.wz2100.net/newticket!", useInputBuffer1 ? inputBuffer[1] : inputBuffer[0], WZ_DBGFile, WZ_DBGFile);
\nDo not forget to upload the %s file, WZdebuginfo.txt and the warzone2100.rpt files in your bug reports at https://github.com/Warzone2100/warzone2100/issues/new", useInputBuffer1 ? inputBuffer[1] : inputBuffer[0], WZ_DBGFile, WZ_DBGFile);

This comment has been minimized.

Copy link
@Forgon2100

Forgon2100 Jun 28, 2019

Contributor

I accidentally deleted an exclamation mark here.
It should be put back in.

@KJeff01

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@Forgon2100 It may be worth splitting the Trac plugin removal into a separate PR (are they still being used?), and taking up the rest of the commits here into a new PR to fix the missing exclamation mark.

Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jul 5, 2019

Update bug tracker URLs
Trac's bug tracker has been dropped in favor of GitHub's issue tracker.

Refs Warzone2100#374
Fixes Warzone2100#427

Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jul 5, 2019

Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jul 5, 2019

Remove Trac plugins to manage tickets
Since Trac's bug tracker was shut down, they are no longer needed.

Refs Warzone2100#374
Fixes Warzone2100#428
@Forgon2100

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@Forgon2100 It may be worth splitting the Trac plugin removal into a separate PR (are they still being used?), and taking up the rest of the commits here into a new PR to fix the missing exclamation mark.

Done.
The contents of this PR are now available in #427 and #428 so that it
can be closed.

@past-due

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Closing this PR. Continues in #427, #428.

@past-due past-due closed this Jul 5, 2019

KJeff01 added a commit that referenced this pull request Jul 5, 2019

Update bug tracker URLs
Trac's bug tracker has been dropped in favor of GitHub's issue tracker.

Refs #374
Fixes #427

KJeff01 added a commit that referenced this pull request Jul 5, 2019

past-due added a commit that referenced this pull request Jul 7, 2019

Remove Trac plugins to manage tickets
Since Trac's bug tracker was shut down, they are no longer needed.

Refs #374
Fixes #428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.