Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve `sendMap()` performance #392

Merged

Conversation

@past-due
Copy link
Contributor

commented Jun 17, 2019

sendMap() was effectively being throttled heavily by vsync / FPS - every call to sendMap() (which is once per frame), it would only call NETsendFile(...) once per file, which sends at most MAX_FILE_TRANSFER_PACKET (which is currently 2048).

This resulted in very slow map / mod transfer times (especially noticeable for larger maps / mods).

past-due added 2 commits Jun 17, 2019
`sendMap()` was effectively being throttled heavily by vsync / FPS - every call to `sendMap()` (which is once per frame), it would only call `NETsendFile(...)` once per file, which sends at most `MAX_FILE_TRANSFER_PACKET`.

This resulted in very slow map / mod transfer times (especially noticeable for larger maps / mods).
@past-due past-due added this to the 3.3.0_beta2 milestone Jun 17, 2019
@past-due past-due merged commit bafc8a4 into Warzone2100:master Jun 17, 2019
6 of 8 checks passed
6 of 8 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
@past-due past-due deleted the past-due:2019_06_improve_sendmap_performance_1 branch Jun 17, 2019
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jun 23, 2019
* remove unnecessary fuzzy flag
* add translation of structure limit screen title
* reinstate translation of hold, pursue and guard orders
* add translation of commander limit messages
* reinstate translation of range orders
* fix format specifiers in map transfer messages

Refs b00b17c
Refs ticket:4871
Refs Warzone2100#263
Refs Warzone2100#329
Refs Warzone2100#314
Refs Warzone2100#392
Fixes Warzone2100#402
past-due added a commit that referenced this pull request Jun 24, 2019
* remove unnecessary fuzzy flag
* add translation of structure limit screen title
* reinstate translation of hold, pursue and guard orders
* add translation of commander limit messages
* reinstate translation of range orders
* fix format specifiers in map transfer messages

Refs b00b17c
Refs ticket:4871
Refs #263
Refs #329
Refs #314
Refs #392
Fixes #402
Forgon2100 added a commit to Forgon2100/warzone2100 that referenced this pull request Jun 28, 2019
* execute `cd po; ./update-po.sh; make update-po`

* fix format specifier in translations of these map downloading messages
  modified in bafc8a4 (refs Warzone2100#392):
  * "Sending Map: %u%% "
  * "Map: %u%% downloaded"

* update all unchanged translations of renamed AIs (refs Warzone2100#281):
  * "Semperfi" -> "SemperFi"
  * "SemperFi JS" -> "SemperFi JavaScript"

Fixes Warzone2100#412
KJeff01 added a commit that referenced this pull request Jun 28, 2019
* execute `cd po; ./update-po.sh; make update-po`

* fix format specifier in translations of these map downloading messages
  modified in bafc8a4 (refs #392):
  * "Sending Map: %u%% "
  * "Map: %u%% downloaded"

* update all unchanged translations of renamed AIs (refs #281):
  * "Semperfi" -> "SemperFi"
  * "SemperFi JS" -> "SemperFi JavaScript"

Fixes #412
@KJeff01 KJeff01 referenced this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.