Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing truck template availability #394

Merged
merged 4 commits into from Jun 18, 2019

Conversation

@KJeff01
Copy link
Contributor

commented Jun 18, 2019

#378 needed more work, unfortunately.

This:

  • Sets the correct droid type for all truck templates in their respective templates.json files.
  • Cleans up a bunch of useless enableTemplate calls in the scripts since the default truck template is always available while the MG viper is always available in campaign.
  • Adds an exception for trucks to not require the player to build a HQ.
  • Reset playerBuiltHQ at game load so design behavior stays consistent across games.

AFAIK, the one issue not addressed so far is the availability of saved truck templates on T2/T3 no bases. If researched they will appear without the HQ.

Refs #393.

@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone Jun 18, 2019

@KJeff01 KJeff01 changed the title [WIP] Fixing truck template availability Fixing truck template availability Jun 18, 2019

@KJeff01 KJeff01 merged commit 15ec435 into Warzone2100:master Jun 18, 2019

7 of 8 checks passed

LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@KJeff01 KJeff01 deleted the KJeff01:templates branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.