Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always initialize SDL before Qt #401

Merged
merged 1 commit into from Jul 2, 2019

Conversation

@past-due
Copy link
Contributor

commented Jun 23, 2019

Some background:

  1. Qt is only used for the scripting engine (and the script debugger window)
  2. There are reports that initializing SDL before Qt fixes crashes on certain Linux configs (depending on the version of SDL and the version of Qt)
  3. SDL must be initialized before Qt on macOS (otherwise there are issues with menus, etc)
  4. It is undesirable to rely on side effects that occur when Qt is initialized first (ex. Windows DPI awareness settings)

@past-due past-due changed the title [WIP] Always initialize SDL before Qt Always initialize SDL before Qt Jun 27, 2019

@past-due past-due added this to the 3.3.0_beta2 milestone Jun 27, 2019

@KJeff01

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

No crashes when I tested this on Linux.

@past-due past-due merged commit ccb70cb into Warzone2100:master Jul 2, 2019

6 of 8 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@past-due past-due deleted the past-due:2019_06_23_init_order_1 branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.