Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade shortHit values in accuracy research #410

Merged
merged 2 commits into from Jun 30, 2019

Conversation

@KJeff01
Copy link
Contributor

commented Jun 26, 2019

The final piece to the ranges/accuracy puzzle. This PR will increase the shortHit values by 10% of the base value for every accuracy upgrade in campaign and multiplayer, just like for longHit.

This fixes two things:

  1. Eventually, all weapons that are better at short range can flip to being better at long range. Provided with enough accuracy upgrades, especially if the difference between a weapon's longHit and shortHit is very close, this situation can certainly happen.
  2. Weapons without any accuracy difference at a given range will keep having an equal longHit and shortHit value.

The result of accuracy upgrades can be seen in the script contexts in the debug window in the Upgrades object (current stat values of all players).

@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone Jun 26, 2019

@KJeff01 KJeff01 merged commit 1896ca1 into Warzone2100:master Jun 30, 2019

6 of 8 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@KJeff01 KJeff01 deleted the KJeff01:accuracyResearch branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.