Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to cam3-1 mission script #416

Merged
merged 2 commits into from Jul 2, 2019

Conversation

@KJeff01
Copy link
Contributor

commented Jul 1, 2019

  • Avoids destroying the base during the brief nuke event, should it still exist when the player enters the safe area. Otherwise it's possible to trigger a base cleanup that destroys the remaining walls during this event and Warzone may leave the player a noisy assert about trying to destroy something already destroyed.
  • I also noticed that structures were being counted in the safe area as units which could prematurely trigger the nuke event. So now it only checks for units in the safe area.

Fixes #415.

KJeff01 added 2 commits Jul 1, 2019
Avoid destroying the base during the cam3-1 nuke event.
For a purely visual event that lasts less than a second, it's not worth
complicating the code if the player chose not to completely destroy the Nexus
base on this mission before entering the safe area.

@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone Jul 1, 2019

@KJeff01 KJeff01 merged commit 71b1005 into Warzone2100:master Jul 2, 2019

6 of 8 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.