Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing AI difficulty buttons for locked teams #423

Merged
merged 1 commit into from Jul 4, 2019

Conversation

@Forgon2100
Copy link
Contributor

commented Jul 3, 2019

With alliances set to either "Locked Teams, No Shared Research" or
"Locked Teams", AI player boxes were shown without difficulty buttons if
all players were on the same team:

skirmish_shared_research_old

The attached ZIP file contains

  • screenshots showing an AI player box with all players on the same team
    and alliances set to either "Locked Teams, No Shared Research" or
    "Locked Teams", both before and after applying this PR when
    • hosting a skirmish game
    • hosting a challenge
    • hosting a multiplayer game
    • joining a multiplayer game
  • a shell script to generate them

missing_difficulty_buttons_documentation.zip

* do not hide AI difficulty buttons with locked teams if all players are
  on the same team

Fixes #423
@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone Jul 3, 2019
@KJeff01

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

Works for me.

@KJeff01 KJeff01 merged commit 63c358c into Warzone2100:master Jul 4, 2019
6 of 8 checks passed
6 of 8 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.