Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offset of default colored cursor #426

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@Forgon2100
Copy link
Contributor

commented Jul 4, 2019

The positioning of the default colored cursor was off by 2 pixels to the
top left. This could be verified by placing it in a window corner:

colored_cursor_offset_old

Increasing the sidelength of the image by 1 pixel and removing a few
blurry pixels fixes the problem:

colored_cursor_offset_new

The attached ZIP file contains

  • the two screenshots shown in this summary
  • a shell script used to generate them

colored_cursor_offset_documentation.zip

Fix offset of default colored cursor
* fix overdrawing of 2x2 pixels to the top left
  * remove a few blurry pixels
  * increase image sidelength by 1 pixel

Fixes #426

@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone Jul 4, 2019

@KJeff01 KJeff01 merged commit 66322c9 into Warzone2100:master Jul 5, 2019

5 of 8 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.