Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SemperFi-js building its fourth research lab. #429

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@KJeff01
Copy link
Contributor

commented Jul 5, 2019

Semperfi-JS was unable to build its forth research lab due to checking the wrong variable (as revealed by LGTM). This meant it had to jump from 3->5 instantly and that could only happen on maps with a decent average of oils per player (12).

SemperFi-JS may not have a perfect research order or build behavior, but the results of having an additional lab with enough oil derricks is always nice on a lot of maps. Here are some simple 2v2 bot battles to show the difference.

  • RollingHills (T1)
  • bases
  • shared research
  • High power
  • Medium difficulties

Test 1
Players:
0 - Cobra v1.30 (rocket personality)
1 - Cobra v1.30 (machinegun personality)
2 - SemperFi-JS
3 - SemperFi-JS

Without patch: Cobra team won in 30 minutes.
With patch: Cobra team won in 47 minutes.

Test 2
Players:
0 - Cobra v1.30 (cannon personality)
1 - Cobra v1.30 (cannon personality)
2 - SemperFi-JS
3 - SemperFi-JS

Without patch: Cobra team won in 35 minutes.
With patch: SemperFi-JS team won in 56 minutes

Overall, SemperFi-JS can prove to be a tougher opponent. For other bots, anyway.

@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone Jul 5, 2019
@lgtm-com

This comment has been minimized.

Copy link

commented Jul 5, 2019

This pull request fixes 1 alert when merging c37e8ba into d4af395 - view on LGTM.com

fixed alerts:

  • 1 for Useless comparison test
@KJeff01 KJeff01 merged commit 6634148 into Warzone2100:master Jul 5, 2019
6 of 8 checks passed
6 of 8 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: JavaScript 1 fixed alert
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
@KJeff01 KJeff01 deleted the KJeff01:semperfijs-fix branch Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.