Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addSubdirs / removeSubdirs: Use platform (in)dependent notation (as appropriate) #441

Merged

Conversation

@past-due
Copy link
Contributor

commented Jul 13, 2019

Possible fix for #440 (needs testing).

@past-due past-due requested a review from KJeff01 Jul 13, 2019

@KJeff01

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

Mods aren't being loaded in Windows (they don't show up in the top-left corner in the frontend). Tried directories autoload and multiplay.

@past-due past-due changed the title Use PHYSFS_getDirSeparator() in more places [WIP] Use PHYSFS_getDirSeparator() in more places Jul 13, 2019

@past-due past-due force-pushed the past-due:2019_07_13_mod_path_separators_1 branch from 70a1a69 to 2a44380 Jul 14, 2019

@past-due past-due changed the title [WIP] Use PHYSFS_getDirSeparator() in more places [WIP] addSubdirs / removeSubdirs: Use platform (in)dependent notation (as appropriate) Jul 14, 2019

@past-due

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2019

@KJeff01: Trying a different approach. (See revised commit.)

@KJeff01

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2019

Tested ArtRev 3.3 and Cobra AI mods on Windows and all downloaded and worked as one would expect. No crashes.

@past-due past-due added this to the 3.3.0_beta2 milestone Jul 14, 2019

@past-due past-due changed the title [WIP] addSubdirs / removeSubdirs: Use platform (in)dependent notation (as appropriate) addSubdirs / removeSubdirs: Use platform (in)dependent notation (as appropriate) Jul 14, 2019

@past-due past-due force-pushed the past-due:2019_07_13_mod_path_separators_1 branch from 427f985 to ffc253d Jul 14, 2019

@past-due past-due marked this pull request as ready for review Jul 14, 2019

@KJeff01
Copy link
Contributor

left a comment

Looks good to me.

@past-due past-due merged commit 1b5fe86 into Warzone2100:master Jul 14, 2019

6 of 8 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@past-due past-due deleted the past-due:2019_07_13_mod_path_separators_1 branch Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.