Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support Wasm-C-API proposal #306

Open
q82419 opened this issue Jul 20, 2021 · 8 comments · May be fixed by #346
Open

Feat: Support Wasm-C-API proposal #306

q82419 opened this issue Jul 20, 2021 · 8 comments · May be fixed by #346
Labels
enhancement New feature or request help wanted Extra attention is needed priority:low

Comments

@q82419
Copy link
Collaborator

q82419 commented Jul 20, 2021

Motivation

The wasm-c-api proposal provides the C and C++ API for WASM runtimes. Even though WasmEdge already provided the C API, it's proper to implement the wasm-c-API proposal for the general C/C++ API.
In the current status, we've already implemented the non-runtime data structures on the branch. Then, we need to finish the runtime implementation.

Specification

  1. Follow the Spec of WASM-C-API proposal and work on the branch.
  2. Implement the WASM C/C++ API by calling the WasmEdge classes or WasmEdge C API.
  3. Add the customized wasm_config_t functions for the runtime configurations.
  4. Complete the Wasm C/C++ API unit tests for the coverage.
  5. Pass the WASM core tests without the SIMD proposal.

Appendix

  1. WASM C API proposal: https://github.com/WebAssembly/wasm-c-api
  2. WASM spec core tests: https://github.com/WebAssembly/spec/tree/master/test/core
@q82419 q82419 linked a pull request Jul 20, 2021 that will close this issue
@q82419 q82419 linked a pull request Aug 10, 2021 that will close this issue
@q82419 q82419 removed a link to a pull request Aug 10, 2021
@q82419 q82419 added enhancement New feature or request help wanted Extra attention is needed labels Aug 10, 2021
@q82419 q82419 changed the title WebAssembly Wasm-C-API proposal Feat: Support Wasm-C-API proposal Aug 10, 2021
@hydai hydai added the LFX Mentorship Tasks for LFX Mentorship participants label Aug 11, 2021
@skant7
Copy link

skant7 commented Aug 11, 2021

Hi @hydai , the project seems interesting and I would like to work on it . As of now I have done local setup and run the tests ,any suggestions on how do I get started with the project and related resources to get started?
Also please do let me know the prerequisites.

@hydai
Copy link
Member

hydai commented Aug 12, 2021

Hi @skant7

Wasm C/C++ API provides an easy way to embedded the Wasm engine in other applications. Because this API is to interact with the Wasm runtime not the Wasm application, you will need to know the execution flow of Wasm files.
WasmEdge provides its own C API, which is not the same as Wasm C API. If you want to start, you can find some previous works in this branch.

And this mission will need the following skills:

  • Strong understanding of C and C++. WasmEdge is written in C++. And the headers of this proposal is defined in both C and C++.
  • Basic knowledge of WebAssembly

@anonymousr007
Copy link

Hi @hydai ,I am final year computer engineering student at Delhi Technological University at India and I would like to work on this project.I am intermediate C++ developer with good knowledge of Data Structures and Algorithms.

Thanks & Regards
Rishabh

@sarath-01
Copy link

Hi @hydai this project seems interesting and I am looking forward to contribute to it. I am pretty much comfortable with C and C++, please let me know about how to get start with the project.

@komalbehera
Copy link

Hi @hydai
I am a final year undergraduate student from NIT Rourkela with strong hold in C/C++. I am quite proficient in Data structures and algorithms and interested to work on this project. It would be great if you could help me get started with this.

@SAtacker
Copy link
Collaborator

SAtacker commented Aug 26, 2021

@hydai Is it still going on?
Where do I have to send a detailed timeline after completion of #365?

@hydai
Copy link
Member

hydai commented Jul 26, 2024

@q82419
Do we have any intention of supporting this proposal? It seems like the upstream is no longer in active development and lack of maintenance.

@q82419
Copy link
Collaborator Author

q82419 commented Jul 29, 2024

The wasm c api proposal only supports finished proposals except SIMD.
I can keep updating to the latest upstream but I think it's in a low priority.

@hydai hydai added priority:low and removed LFX Mentorship Tasks for LFX Mentorship participants labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed priority:low
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

7 participants