-
Notifications
You must be signed in to change notification settings - Fork 62
Add example for wasm_bpf
plugin
#75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the Pull Request seems well-prepared and the changes seem well-explained. The potential problems that were identified have been addressed. The addition of a new DetailsCommit b18ff36c9c4a47e0d8a790aee2c92c4a4954bcf0Key changes:
Potential problems:
Commit 0cb40e460abe8f307e3c4181855acd860a55e361Key changes:
Potential problems:
Commit 5e022edbcae3fc98fdfdfb92990ac21b677ddd35Key changes:
Potential problems:
|
@Officeyutong The DCO check is failing, could you please sign-off your commits? |
Fixed now |
For simplicity, we will just reuse the `Makefile` of [wasm-bpf](https://github.com/eunomia-bpf/wasm-bpf), since `wasmEdge_bpfPlugin` has the exactly same API as `wasm-bpf` | ||
|
||
1. Clone the [`wasm-bpf`](https://github.com/eunomia-bpf/wasm-bpf) repo. | ||
2. Run `make install-deps` and `make /opt/wasi-sdk` at the root of the project. This will install the build prerequisites. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: officeyutong <yt.xyxx@gmail.com>
Signed-off-by: officeyutong <yt.xyxx@gmail.com>
Signed-off-by: officeyutong <yt.xyxx@gmail.com>
This looks great! Can you also add a section on how to install the eBPF plugin here? https://wasmedge.org/docs/develop/build-and-run/install/#install-wasmedge-with-plugins-1 Thanks. |
The install script doesn't seem to support installing wasm_bpf plugin yet, it only supports plugins with their names hardcoded in the script |
Maybe we can open a pr and add the wasm_bpf plugin in it? |
I will merge this first. When we have the installer for e-bpf plugin, the doc needs to be updated. |
Add an document page for the
wasm_bpf
plugin, demonstrating how to write programs use the API provided by that plugin