Skip to content

simple tile improvements #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2021
Merged

simple tile improvements #1071

merged 5 commits into from
Jun 8, 2021

Conversation

ammen99
Copy link
Member

@ammen99 ammen99 commented Jan 30, 2021

This PR is aimed at improving simple-tile's behavior.

Goals:

@ammen99 ammen99 marked this pull request as draft January 30, 2021 09:43
@ammen99
Copy link
Member Author

ammen99 commented May 21, 2021

  • Add plugin API for simple-tile so that users can make custom plugins which modify the tiling layout
  • Fix Master and stack layout for tiling mode #771 by using the tile API to build a simple plugin for setting up master/stack (and fat) layouts

@Javyre as far as I understand, these things would be eventually available in swayfire, right?

@Javyre
Copy link
Contributor

Javyre commented May 21, 2021

@Javyre as far as I understand, these things would be eventually available in swayfire, right?

Yup

I intend to expose a public API for swayfire to modify the layout and query the node trees. (This won't come until at least 0.2)
It should also eventually support custom rules for where to place new opened nodes. (I'm still thinking about how best to achieve this)

I'm going to start a lua-wayfire integration experiment soon to see if these custom rules can be implemented by users in lua. That way a master/stack layout can be achieved by setting a custom function to execute for where to place new opened views as well as custom bindings for what to do when you move nodes up/down/left/right.

@ammen99
Copy link
Member Author

ammen99 commented May 21, 2021

@Javyre as far as I understand, these things would be eventually available in swayfire, right?

Yup

I intend to expose a public API for swayfire to modify the layout and query the node trees. (This won't come until at least 0.2)
It should also eventually support custom rules for where to place new opened nodes. (I'm still thinking about how best to achieve this)

I'm going to start a lua-wayfire integration experiment soon to see if these custom rules can be implemented by users in lua. That way a master/stack layout can be achieved by setting a custom function to execute for where to place new opened views as well as custom bindings for what to do when you move nodes up/down/left/right.

Sounds perfect ;)

In this case, I don't think it makes sense for me to duplicate the same functionality in Wayfire.

@ammen99 ammen99 force-pushed the tile-improvements branch from d008f17 to f2370a5 Compare June 2, 2021 07:29
@ammen99 ammen99 marked this pull request as ready for review June 2, 2021 07:29
@ammen99 ammen99 force-pushed the tile-improvements branch from f2370a5 to 3db67a1 Compare June 2, 2021 07:34
ammen99 added 5 commits June 8, 2021 11:51
This works in the move mode, if dragging one view to the center of the
other.
Grid has public API which should be installed. So it needs a separate
directory with its files.
This avoids useless resizing of the child view.
@ammen99 ammen99 force-pushed the tile-improvements branch from 8dfe3fd to cbe5a34 Compare June 8, 2021 10:07
@ammen99 ammen99 merged commit b437459 into master Jun 8, 2021
@ammen99 ammen99 deleted the tile-improvements branch June 8, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants