Skip to content

Implement switch to last workspace feature for vswitch plugin #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

l3nkz
Copy link
Contributor

@l3nkz l3nkz commented Nov 29, 2021

Extend the vswitch plugin with bindings that allow switching back to the
last active workspace. The functionality is achieved by always
remembering the switching direction at each switch, so that we can
easily reverse it. There in now not only a binding for switching to the last
workspace, but also two other bindings: 1) for taking the current view
with when switching and 2) for only sending the currently focused view
to the last workspace.

Fixes #1296

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a whole, LGTM, please fix the formatting issues.

Extend the vswitch plugin with bindings that allow switching back to the
last active workspace. The functionality is achieved by always
remembering the switching direction at each switch, so that we can
easily reverse it. There is not only a binding for switching to the *last*
workspace, but also two other bindings: 1) for taking the current view
with when switching and 2) for only sending the currently focused view
to the *last* workspace.
@l3nkz
Copy link
Contributor Author

l3nkz commented Nov 29, 2021

I updated the PR with your comments and checked that uncrustify does not complain for my code changes.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to last workspace
2 participants