Skip to content

Implement StatusNotifierItem #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 13, 2023
Merged

Implement StatusNotifierItem #153

merged 14 commits into from
Jul 13, 2023

Conversation

NamorNiradnug
Copy link
Collaborator

@NamorNiradnug NamorNiradnug commented Jul 7, 2023 •
edited
Loading

Fix #29

WIP features include:

  • handling SNI's New* signals
  • working properly with blueman-applet (currently I have no idea what's wrong it was a missing invocation->return_value(...) call)
  • config options

@NamorNiradnug NamorNiradnug marked this pull request as ready for review July 8, 2023 16:43
This was referenced Jul 8, 2023
Open
Open
ammen99
ammen99 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My knowledge of SNI is very limited, so I have not reviewed the PR in detail. But it looks good, I also tested it and it seems to work, at least with VLC. Great work and thanks for the PR!

@ammen99 ammen99 merged commit cc2578e into WayfireWM:master Jul 13, 2023
@ammen99
Copy link
Member

ammen99 commented Jul 13, 2023 •
edited
Loading

Hmm, @NamorNiradnug, nm-applet does not show up here, any ideas why that might be the case? Nvm, I had to use --indicator, seems to work well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add status notifier item in wf-panel
2 participants
@NamorNiradnug @ammen99