Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Compilation #229

Closed
wqweto opened this issue Jun 17, 2021 · 2 comments
Closed

Conditional Compilation #229

wqweto opened this issue Jun 17, 2021 · 2 comments
Labels
bug Something isn't working confirmed the issue has been verified

Comments

@wqweto
Copy link

wqweto commented Jun 17, 2021

Describe the bug
Project level introduced Conditional Compilation consts are not resolved on preprocessor #Const lines

To Reproduce

  1. In Project Settings use in Conditional Compilation this
MY_TEST=1
  1. This test code fails to run
Module TestModule
    #Const ImplTest = (MY_TEST=1)

    #If ImplTest Then
    Public Sub Main()
    End Sub
    #End If
End Module

Additional context
The project settings page says "Enter a comma delimited list of name=value pairs used by the compiler during conditional compilation evaluation". Does this deliberately differ from VBA/VB6 colon (:) separated list?

Btw, the consts from project settings are always Variants of String sub-type while #Const introduced can be Variants of any sub-ype (e.g. #Const ImplTest = (MY_TEST=1) must be a Boolean sub-type (the result of comparing a string to an integer literal).

@WaynePhillipsEA
Copy link
Collaborator

WaynePhillipsEA commented Jun 17, 2021

Project level compilation conditional arguments are not yet hooked into the parser, so they are being completely ignored.

@WaynePhillipsEA WaynePhillipsEA added bug Something isn't working confirmed the issue has been verified labels Jun 17, 2021
@WaynePhillipsEA
Copy link
Collaborator

Fixed in v0.10.2532, thanks for reporting. Any errors in the project-level compilation arguments are not gracefully handled yet, but they are parsed and passed to the compiler correctly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed the issue has been verified
Projects
None yet
Development

No branches or pull requests

2 participants