Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ADSR hanging notes #622

Closed
wants to merge 1 commit into from

Conversation

@maxwellpollack
Copy link

maxwellpollack commented Oct 22, 2019

Currently, notes released before decaying to the sustain level have longer release times (inversely proportional to the sustain level), which is strange behavior for an ADSR envelope. This fix ensures that all notes have the same release times.

ADSR sustain and release stage not working properly

Bug in ADSR?

Currently, notes released before decaying to the sustain level have longer release times (inversely proportional to the sustain level), which is strange behavior for an ADSR envelope. This fix ensures that all notes have the same release times.
@ed95

This comment has been minimized.

Copy link
Collaborator

ed95 commented Nov 4, 2019

Added in 91513f5, thanks!

@ed95 ed95 closed this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.