Add New Gif Example to README.md #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianschiavo
suggested changes
Jul 31, 2018
There was a problem hiding this comment.
I think this PR should wait for #41 to merge as it includes a new UI for the scanning interface, so waiting would avoid having to remake another GIF + PR for the new UI.
AvdLee
approved these changes
Jul 31, 2018
There was a problem hiding this comment.
I agree we should merge this in now to let the user understand the repo better.
@justjs for your understanding; we're currently trending on Github, meaning we get quite some traffic in. Let's update the GIF as soon as your PR is merged in instead of waiting to merge. We can benefit from the traffic here!
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.