This repository was archived by the owner on Dec 29, 2024. It is now read-only.
Simplified callp interactions with arguments#116
Merged
Merged
Conversation
Trey2k
force-pushed
the
dev/callpArgs
branch
3 times, most recently
from
db0d47b to
1dd4555
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our previous method of passing arguments to callp was a little crude. In discord a bug was brought up which was intermittent and unpredictable. It was noticed when calling methods on objects. Results would very on weather args would be properly sent under certain conditions. I still do not fully understand where or why the bug happened. But I simplified the method of allocating space for arguments and it seems to be resolved now.
CC @Griiimon