This repository was archived by the owner on Dec 29, 2024. It is now read-only.
RC1 Prep#131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr ties up a couple of lose ends in prep for RC1. One major issue we had was LuaCallableCustom's only worked in module builds since GDExtension does not expose access to CallableCustom's. In this PR we worked around that by adding a call_function_ref method to LuaAPI. This method is not meant to be called directly, but rather when pulling a function from lua we binding its reference and return that Callable to the user. In which case the only argument would be the Array of args. This should bring the Module and GDExtensions API's to a 1:1 compatibility.
This PR also changes permissive default to true in order to stay closer to the functionality that existed before that change.
And finally there was also some small cleanup tasks that have been completed.