Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'required' attribute where possible in submission pages #175

Merged

Conversation

@kfkitsune
Copy link
Member

kfkitsune commented Sep 27, 2016

For #173.

Adds the HTML5 'required' attribute when possible to catch some input validation errors client-side, which would otherwise be caught server-side.

Does not address the search tag issue, unfortunately. I inspected the source of the tag, and however the JavaScript that's operating on the space/comma action adds a new <ul> item (or something along those lines), and as such it doesn't modify either the textarea or the input tags (though even the input tag isn't actually in the source templates; added by JS, maybe?). Here's the example on the live site of this behavior: https://i.sli.mg/hj3Ar7.png

Adds the HTML5 'required' attribute when possible to catch input validation errors client-side, which would otherwise be caught server-side.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 27, 2016

Current coverage is 47.76% (diff: 100%)

Merging #175 into master will not change coverage

@@             master       #175   diff @@
==========================================
  Files           143        143          
  Lines         11758      11758          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5616       5616          
  Misses         6142       6142          
  Partials          0          0          

Powered by Codecov. Last update e26146b...296f04f

@charmander charmander merged commit 1e65d2a into Weasyl:master Oct 29, 2016
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing e26146b...296f04f
Details
codecov/project 47.76% (+0.00%) compared to e26146b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kfkitsune kfkitsune deleted the kfkitsune:html5-required-attrib-submissions branch Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.