New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 11 CollectionJsonController Create method should return a TId instead of an int #12

Merged
merged 2 commits into from Aug 17, 2013

Conversation

Projects
None yet
2 participants
@gabrewer

gabrewer commented Aug 17, 2013

Updated CollectionJsonController Create method and added unit tests for Controllers with generic identifiers

@glennblock

This comment has been minimized.

Show comment
Hide comment
@glennblock

glennblock Aug 17, 2013

Member

Nice!

-----Original Message-----
From: "Greg Brewer" notifications@github.com
Sent: ‎8/‎17/‎2013 12:49 PM
To: "WebApiContrib/WebApiContrib.Formatting.CollectionJson" WebApiContrib.Formatting.CollectionJson@noreply.github.com
Subject: [WebApiContrib.Formatting.CollectionJson] Fix for issue 11CollectionJsonController Create method should return a TId instead of an int(#12)

Updated CollectionJsonController Create method and added unit tests for Controllers with generic identifiers

You can merge this Pull Request by running
git pull https://github.com/gabrewer/WebApiContrib.Formatting.CollectionJson masterOr view, comment on, or merge it at:
#12
Commit Summary
Fixed issue 11. CollectionJsonController Create method should return a TId instead of an int
Added unit test for generic CollectionJsonControllers
File Changes
M src/WebApiContrib.Formatting.CollectionJson.Server/CollectionJsonController.cs (2)
A test/WebApiContrib.Formatting.CollectionJson.Server.Tests/CollectionJsonControllerWithTIdTests.cs (156)
M test/WebApiContrib.Formatting.CollectionJson.Server.Tests/WebApiContrib.Formatting.CollectionJson.Server.Tests.csproj (1)
Patch Links:
https://github.com/WebApiContrib/WebApiContrib.Formatting.CollectionJson/pull/12.patch
https://github.com/WebApiContrib/WebApiContrib.Formatting.CollectionJson/pull/12.diff

Member

glennblock commented Aug 17, 2013

Nice!

-----Original Message-----
From: "Greg Brewer" notifications@github.com
Sent: ‎8/‎17/‎2013 12:49 PM
To: "WebApiContrib/WebApiContrib.Formatting.CollectionJson" WebApiContrib.Formatting.CollectionJson@noreply.github.com
Subject: [WebApiContrib.Formatting.CollectionJson] Fix for issue 11CollectionJsonController Create method should return a TId instead of an int(#12)

Updated CollectionJsonController Create method and added unit tests for Controllers with generic identifiers

You can merge this Pull Request by running
git pull https://github.com/gabrewer/WebApiContrib.Formatting.CollectionJson masterOr view, comment on, or merge it at:
#12
Commit Summary
Fixed issue 11. CollectionJsonController Create method should return a TId instead of an int
Added unit test for generic CollectionJsonControllers
File Changes
M src/WebApiContrib.Formatting.CollectionJson.Server/CollectionJsonController.cs (2)
A test/WebApiContrib.Formatting.CollectionJson.Server.Tests/CollectionJsonControllerWithTIdTests.cs (156)
M test/WebApiContrib.Formatting.CollectionJson.Server.Tests/WebApiContrib.Formatting.CollectionJson.Server.Tests.csproj (1)
Patch Links:
https://github.com/WebApiContrib/WebApiContrib.Formatting.CollectionJson/pull/12.patch
https://github.com/WebApiContrib/WebApiContrib.Formatting.CollectionJson/pull/12.diff

glennblock added a commit that referenced this pull request Aug 17, 2013

Merge pull request #12 from gabrewer/master
Fix for issue 11 CollectionJsonController Create method should return a TId instead of an int

@glennblock glennblock merged commit 925941f into WebApiContrib:master Aug 17, 2013

@glennblock

This comment has been minimized.

Show comment
Hide comment
@glennblock

glennblock Aug 17, 2013

Member

Awesome, thanks!

Member

glennblock commented Aug 17, 2013

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment