wasi_unstable_preview0.witx: fixes to match current implementations #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
force-pushed
the
pch/witx_corrections
branch
from
b74967f to
867841b
Compare
pchickey
force-pushed
the
pch/witx_corrections
branch
from
867841b to
14d2ac3
Compare
Member
|
My sense here is that it's early enough that we can go ahead and change |
sunfishcode
approved these changes
Sep 30, 2019
Contributor
Author
|
Agreed, this is a special case because we're trying to get the starting point of the witx spec to match reality (where wasi was specified by the libc's Should we also port these fixes into |
Member
|
Yes, I think it makes sense to update |
Contributor
Author
|
Put the patches into |
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
* wasi_unstable_preview0.witx: fixes to match current implementations * old/wasi_unstable.witx: fixes to match current implementations * wasi_ephemeral_preview0.witx: fixes to match current implementations
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
* wasi_unstable_preview0.witx: fixes to match current implementations * old/wasi_unstable.witx: fixes to match current implementations * wasi_ephemeral_preview0.witx: fixes to match current implementations
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
…ebAssembly#100) * Fix the extra argument to `append-via-stream`, and misc. doc updates Fix a spurious extra argument to `append-via-stream`. Also, add some miscellaneous documentation updates, including: - Describing filesystem path separators and sandboxing behavior - Clarifying that streams are independent of each other. - Remove stale references to the `append` flag. * More minor formatting fixes. * Document that `symlink-at` can't create absolute-path symlinks.
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
…bly#110) Remove the spurious second argument in `append-via-stream`, which is an oversight from the conversion from resources to standalone functions. I meant to do this in WebAssembly#100 but apparently lost that part of the diff. This PR reinstatates it.
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
refactor the imports to its own world
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
* wasi_unstable_preview0.witx: fixes to match current implementations * old/wasi_unstable.witx: fixes to match current implementations * wasi_ephemeral_preview0.witx: fixes to match current implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to
wasi_unstable_preview0.witxto align with the current implementations (wasi-libc, wasi-common, and the wasi rust crate)environ_sizes_getreturns anerrno_tas its first resultpath_opentakes afdflags_targument.proc_sched_yieldis actually calledsched_yieldOpen question: These changes are seeking to make the witx document descriptive, rather than prescriptive.
wasi_unstable_preview0.witxis also out of sync with current implementations by using thewasi_unstable_preview0module name, where current implementations usewasi_unstable.Should we instead make
phases/old/witx/wasi_unstable.witxthat describes current (pre-preview0) implementations? Or shouldpreview0?