Rename $subscription_fd_readwrite's $fd member to $fd. #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more consistent with naming through the rest of the witx specs.
Contributor
pchickey
approved these changes
Jan 15, 2020
Contributor
|
Sorry, fat finger closed it by accident |
Contributor
|
@sunfishcode Since we've landed #203, would you mind changing lines typenames.witx#L490 and typenames.witx#L493 so that the links there now read |
Member
Author
|
This patch only applies to the ephemeral directory; the field is still named |
Contributor
Ahh, gotcha! I missed that one, sorry! |
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
This makes it more consistent with naming through the rest of the witx specs.
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
This makes it more consistent with naming through the rest of the witx specs.
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
Release v0.2.8
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
This makes it more consistent with naming through the rest of the witx specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more consistent with naming through the rest of the witx
specs.