Skip to content

Conversation

@ricochet
Copy link
Contributor

@ricochet ricochet commented Nov 25, 2025

This validates the wit definitions for both 0.2.* and 0.3.*

I have not added the update and publish workflows but will add those in a following PR once we land on the approach (use matrix for filter paths so we're only building what changed).

@ricochet ricochet force-pushed the ricochet/ci branch 2 times, most recently from e63f5ef to 610859c Compare November 25, 2025 20:15
@yoshuawuyts
Copy link
Member

After we merge this we should add the following ruleset to the repo via Settings → Rules → Rulesets → New ruleset → Import a ruleset so we require all status checks to pass before a PR can be merged:

{
  "name": "Require All Status Checks to Pass",
  "target": "branch",
  "enforcement": "active",
  "conditions": {
    "ref_name": {
      "include": [
        "~DEFAULT_BRANCH"
      ],
      "exclude": []
    }
  },
  "rules": [
    {
      "type": "required_status_checks",
      "parameters": {
        "strict_required_status_checks_policy": true,
        "do_not_enforce_on_create": false,
        "required_status_checks": [
          "Validate WIT"
        ]
      }
    }
  ],
  "bypass_actors": []
}

yoshuawuyts
yoshuawuyts previously approved these changes Nov 26, 2025
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neatttt, ty!

Signed-off-by: Bailey Hayes <bailey@cosmonic.com>
@ricochet ricochet marked this pull request as ready for review November 26, 2025 21:57
@ricochet ricochet requested a review from a team as a code owner November 26, 2025 21:57
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We went over this PR together earlier today; excited to be moving forward with this!

@yoshuawuyts yoshuawuyts added this pull request to the merge queue Nov 26, 2025
Merged via the queue into WebAssembly:main with commit 6ce5f72 Nov 26, 2025
2 checks passed
@ricochet ricochet deleted the ricochet/ci branch December 1, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants