fix: pin deps to relative paths #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
approved these changes
Dec 1, 2025
rvolosatovs
reviewed
Dec 1, 2025
ricochet
force-pushed
the
relative-deps
branch
3 times, most recently
from
773dd75 to
1784a33
Compare
yoshuawuyts
previously approved these changes
Dec 1, 2025
Member
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
Minor nit, otherwise this looks good. Loving the diff, hah.
yoshuawuyts
reviewed
Dec 1, 2025
Note this caught and required an update to 0.3.0-draft proposals to get the latest types for clocks. Deps are now gitignored and were removed from the git index via: `git rm -r --cached proposals/*/wit/deps/ proposals/*/wit-0.3.0-draft/deps/`
ricochet
force-pushed
the
relative-deps
branch
from
1784a33 to
501dbbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using wit-deps, we pass in paths to the dependencies for each proposal.
This allows for monatonic updates across proposals, e.g. introducing a new feature in clocks and consuming in filesystem.