Make witx document describing wasi spec available as the wasi-spec crate
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 24, 2019 13:56
…l invariants the definitions/entries pattern involves upgrading Weak into Rc and also its not super intuitive, especially given ive written zero (0) docs. This is a bit nicer to use
this makes it easier for others to use the spec without depending on this repo directly
because there are multiple crates now
pchickey
changed the title
wasi cratewasi-spec crate
the wasi name is already taken on crates.io by the official wasi bindings. i never even looked, sloppy work!
pchickey
force-pushed
the
pch/wasi_crate
branch
from
8d7c5e6 to
b75f3ac
Compare
sunfishcode
reviewed
Sep 25, 2019
| for (phase, version) in WASI_VERSIONS { | ||
| let doc = | ||
| load_wasi_spec(phase, version).expect(&format!("load wasi {} {}", phase, version)); | ||
| serialize_wasi_spec(phase, version, &doc); |
Member
There was a problem hiding this comment.
It's not immediately clear what this build.rs program is doing. Why do we need to load and serialize the witx here?
Contributor
Author
|
Sorry, this was a bad idea, I didn't realize this won't work unless built from the git repo. The spec .witx files won't be present if this crate is downloaded from crates.io and the build.rs will fail. |
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
yoshuawuyts
pushed a commit
to yoshuawuyts/WASI
that referenced
this pull request
Nov 25, 2025
…-wasi-sockets Update to the latest wasi-sockets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #96
Over in Lucet, we need to consume the
witxdescription of the WASI spec in several different rust crates. Rather than put each crate in charge of finding and parsing.witxfiles from the filesystem, and and to provide an easy mechanism to use the same version of the spec across the project, I have created thewasi-speccrate in this project.wasi-spechas a build.rs step to serialize the witx document into a single file, and usesinclude_str!andwitx::parseto make the document available in the crate. At the moment it only packageswasi_unstable_preview0. We can package the other phases as well if desired.I'm not sure if packaging the spec as a crate is exactly the right thing to do, but it is useful to me, and might be useful to others as well, so I figured it can live here rather than in the Lucet crate. I am open to feedback about whether this is the right way to package it or the right place for this code to live.