New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlining improvements #1375

Merged
merged 2 commits into from Jan 24, 2018

Conversation

Projects
None yet
1 participant
@kripken
Member

kripken commented Jan 19, 2018

  • If optimizing after inlining, always inline things with a body of size 1 - they will be smaller than the call they are replacing (after optimizing)
  • Fix some inlining issues with deciding how to inline. We need to not inline into something we just inlined, etc. in the same iteration, or we may get loops or suboptimal results.

See background discussion in #1364

@kripken

This comment has been minimized.

Member

kripken commented Jan 19, 2018

Surprisingly useful. I see code size reductions of 0.5% on libc++ for example.

With more complex analysis we can inline even more, the heuristics are still quite simple.

@kripken kripken merged commit f9e49c0 into master Jan 24, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kripken kripken deleted the inlining branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment