Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFinalize tail call support #2246
Merged
Conversation
|
Nice work! |
src/passes/Inlining.cpp
Outdated
| isUnreachable = true; | ||
| break; | ||
| } | ||
| } |
This comment has been minimized.
This comment has been minimized.
kripken
Jul 21, 2019
Member
I feel this logic should be in ir/ as a utility function. Perhaps in a file for utilities for ExpressionLists (which doesn't exist yet). Or maybe is there some functional programming-style way to write this in modern C++?
This comment has been minimized.
This comment has been minimized.
tlively
Jul 21, 2019
Author
Collaborator
This would be a good job for std::any_of, which I just learned exists
src/wasm/wasm-validator.cpp
Outdated
| } else { | ||
| if (curr->type == unreachable) { | ||
| bool hasUnreachableOperand = false; | ||
| for (auto* op : curr->operands) { |
This comment has been minimized.
This comment has been minimized.
src/wasm/wasm-validator.cpp
Outdated
| if (curr->target->type != unreachable) { | ||
| bool hasUnreachableOperand = false; | ||
| for (auto* op : curr->operands) { | ||
| if (op->type == unreachable) { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The fuzzer just passed 100,000 iterations on this PR! |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the replies, sgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tlively commentedJul 21, 2019
•
edited
Adds tail call support to fuzzer and makes small changes to handle return calls in multiple utilities and passes. Makes larger changes to DAE and inlining passes to properly handle tail calls.